Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages/scripts #9625

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Remove packages/scripts #9625

merged 1 commit into from
Oct 22, 2024

Conversation

timolegros
Copy link
Collaborator

@timolegros timolegros commented Oct 22, 2024

Link to Issue

Closes: #9624

Description of Changes

  • Moves the scripts in packages/scripts to packages/commonwealth/scripts/

Test Plan

Deployment Plan

  1. Update Heroku scheduler jobs to use node to run the native JS scripts.

Other Considerations

  • This is a vastly simpler change than modifying the Docker build process to include the packages/scripts since right now the root context is the commonwealth package itself.
  • The only negative aspect of this is that script TS mode will no longer apply to the 2 scripts that were moved. I think this is fine given that the scripts have not changed since creation and the alternative is 3-5 points to modify build process.

@github-actions github-actions bot marked this pull request as draft October 22, 2024 11:55
@timolegros timolegros marked this pull request as ready for review October 22, 2024 11:55
@timolegros timolegros merged commit 92607b2 into master Oct 22, 2024
11 checks passed
@timolegros timolegros deleted the tim/remove-scripts-package branch October 22, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Heroku Scheduler Jobs
3 participants